search

pfernie / reqwest_cookie_store

Apache License 2.0
26 stars 16 forks source link

Serde for CookieStoreMutex and CookieStoreRwlock #6

Closed pxp9 closed 1 year ago

pxp9 commented 1 year ago

please could we provide serde to this crate ?

I have put as feature, so it is optional to have it.

you pay for what you use.

pfernie commented 1 year ago

Thanks for the PR; this seems like a useful opt-in. Do we need to be enabling the rc feature for serde? Looking at the documentation I am not sure it is a feature we would want to enable by default. While it is natural to wrap a cookie_store in an Rc/Arc, that is a feature of serde that the user can enable in their Cargo.toml instead.

pxp9 commented 1 year ago

you were right , it is not needed to have rc feature in order to compile the code.

I will delete it.

pfernie commented 1 year ago

Great; thanks again for the PR, this is merged!