search

pfgray / ts-adt

Generate Algebraic Data Types and pattern matchers
MIT License
314 stars 13 forks source link

Rename `matchI` to `matchItem` #4

Closed NickSeagull closed 3 years ago

NickSeagull commented 4 years ago

Hello!

Thanks for the effort of creating this library, it is very useful 😃

I'm proposing here renaming matchI to matchItem as in larger teams with many people, matchI is not obvious at first sight, in fact I had to get into the library code to understand what was going on.

I think that this change would help many people adopting the library, thanks again!

pfgray commented 3 years ago

@NickSeagull , Thanks for the contribution! I'm going to leave this as matchI, since it actually stands for "inverted" (it inverts the parameter order for better inference in some places. I personally find myself using match more often, since I often code inside of an fp-ts pipe()!