pfirmstone / JGDMS

Infrastructure for providing secured micro services, that are dynamically discoverable and searchable over ipv6 networks
https://pfirmstone.github.io/JGDMS/
Apache License 2.0
14 stars 4 forks source link

compiler <release> tag requires maven 3.6+ #94

Closed bhamail closed 5 years ago

bhamail commented 5 years ago

I was debugging a CI build failure, and I think the cause is the use of a new compiler tag that is only valid in maven version >= v3.6. Do we want/need that requirement now?

Assuming not, I removed the tag so older maven versions will still work.

(My CI build using an older maven version succeeded, so I'm pretty sure this PR fixes the issue). Please ignore the unrelated commit comment below - side effect of merging upstream.

pfirmstone commented 5 years ago

Hi Dan,

I was having problems getting groovy to compile on Java 11 when I added the tag.

I'll try it again without the tag to check it's not required.

Thanks,

Peter.

pfirmstone commented 5 years ago

I have confirmed the tag isn't required.

pfirmstone commented 5 years ago

Thanks Dan.