search

pfitzseb / ProfileCanvas.jl

MIT License
88 stars 6 forks source link

Make flame height adjustable #19

Open charleskawczynski opened 2 years ago

charleskawczynski commented 2 years ago

It's difficult to get an overall view of very deep traces with the existing flame height. It might be nice to make this adjustable. It looks like this padding is what I'd like to adjust (but first split vertical / horizontal padding)

pfitzseb commented 2 years ago

This is really weird -- I was wondering why your screenshots in #16 looked so weird. This is what it should look like: image

The padding you pointed out is in pixels* and added to the font height to calculate the bar height, IIRC, so you really shouldn't get that much padding.

Can you give me some info on what OS/browser you're using and what default font is set?

* Browser pixels, not device pixels, which differ by devicePixelRatio.

charleskawczynski commented 2 years ago

Ah, that looks nicer indeed.

I'm on a MacOS Monterey, Version 12.5.1.

And I'm using Brave, version 1.42.97 Chromium: 104.0.5112.102 (Official Build) (x86_64)

But I can confirm that I see the same thing on Chrome, Version 105.0.5195.52 (Official Build) (x86_64)

Hmm, I'm also seeing the same thing on my windows machine, with Chrome.

pfitzseb commented 2 years ago

I know that Brave has a privacy feature that (sometimes) prevents correct font size measurements. Do you have extensions installed on Chrome that do something similar?

charleskawczynski commented 1 year ago

Ah, sorry for the late response. I don't think I have any privacy features on there, I think I tried once in incognito mode.

Maybe setting the height is something that could be done via Preferences.jl?