search

pfitzseb / ProfileCanvas.jl

MIT License
87 stars 6 forks source link

Add search bar #24

Open charleskawczynski opened 1 year ago

charleskawczynski commented 1 year ago

I think it'd be really useful if we could add a search bar. It would be nice if the flame graph dynamically changed or, just as useful, if the results were presented on a new / separate page.

For example, I'd love to be able to search: Flags: GC and see all the flames that have GC.

pfitzseb commented 1 year ago

Are you looking for filtering, highlighting, or both?

charleskawczynski commented 1 year ago

I had filtering in mind 🙂. I see that highlighting for Flags: GC works already, and that's great until the flames get so narrow (for complicated flame graphs) that you still need to zoom in to see the colors, which is what I'm running into.

charleskawczynski commented 1 year ago

Is this something that mostly needs implemented on the javascript side?

pfitzseb commented 1 year ago

Yes.