Version number is not getting set correctly.

pflagerd / candle2

GRBL control interface in Qt.

GNU General Public License v3.0

0 stars 0 forks source link

Closed pflagerd closed 3 months ago

pflagerd commented 3 months ago

frmAbout.h line 14:

ui->lblAbout->setText(ui->lblAbout->text().arg(qApp->applicationVersion()));

I don't know what he thought he was setting, but it was clearly NOT the actual ui About.

pflagerd commented 3 months ago

I was wrong. What looked like a sad hack was a necessity to extend the frmAbout class. Yuck. Just gross C++ nuance.

Turns out the solution was as simple as editing the frmabout.ui, because he'd forgotten to put %1 instead of a specific version 2.6.

As of db8579b0ef7e701d78c93d11f32875476103329d: