pflarue / ardop

ardopcf - A multi-platform implementation of the Amateur Radio Digital Open Protocol (ARDOP)
Other
30 stars 7 forks source link

Fix 1 Carrier PSK frame TX audio frequency #28

Closed pflarue closed 6 months ago

pflarue commented 6 months ago

Fix a bug that caused 1 Carrier PSK frames to transmit on the wrong audio frequency. This made these frames much harder to correctly decode, and increased the bandwidth of these modes. These are 3 of the 5 modes used for 200 bandwidth connections and 2 of the 6 used for 500 bandwidth connections. Thus, when connecting to those Winlink stations that only accept 500 bandwidth connections, as many do, this may significantly improve performance under less than optimal band conditions.

A couple of additional fixes are included in this pull request, including one that avoids mistakenly accepting a ConReq2000F when ARQ bandwidth is set to 1000MAX.

For diagnostic purposes, a new function was created to identify the peak frequency in a set of audio samples. This function was instrumental in identifying and fixing the audio frequency bug.