pflarue / ardop

ardopcf - A multi-platform implementation of the Amateur Radio Digital Open Protocol (ARDOP)
Other
30 stars 7 forks source link

Remove unused code #61

Closed pflarue closed 5 months ago

pflarue commented 5 months ago

Before this branch the source files used to build ardopcf contained large amounts of unused source code. Much of this consisted of functions that were never referenced or execution branches whose conditions would never be met. Some of this code was intended to support transmit and receive of modulation types and baud rates incompatible with the v1 Ardop specification that ardopcf intends to maintain compatibility with. This branch removes much of this unused code.

Removing this code should not change any behavior or functionality of ardopcf. However, some code was rewritten to remove unnecessary complexity relating to the unused source code. This rewriting may have introduced unintentional changes. Continued testing is therefore planned before including these changes in the next release of ardopcf. The hope is that any harmful unintentional changes made can be identified and fixed before then.

By removing unused code from the repository, it makes the remaining code easier to understand and easier to maintain.