search

pflarue / ardop

ardopcf - A multi-platform implementation of the Amateur Radio Digital Open Protocol (ARDOP)
Other
30 stars 7 forks source link

Issue #66 fix: Reset last acked data frame type when in DISC protocol state #70

Closed Dinsmoor closed 4 months ago

Dinsmoor commented 4 months ago

Should help with Issue #66 (for ardopcf) Will not fix ardopcf connecting to a station that does not have the corrected logic, such as AROP_WinTNC (almost all current Winlink RMS stations)

Tested with two ardopcf stations running Pat, 50+ sessions with average of 5 data frames used per session, variable frame decoding conditions, ensuring that some frames are not decoded properly, increasing chance of this fringe control case.

I would have liked to test this in place of ARDOP_WinTNC for a more in-place fix.

Dinsmoor commented 4 months ago

I'm closing this pull request because ardopcf does not have this bug anymore, as it was fixed on 3/15/2018 (ARQ.c:318).

The windows implementation of the ardop protocol still has this bug, and effort should be made to work with the Winlink guys to get this fixed for the many ardop stations out there that suffer from this.