A few adjustments to followup PR #79 which reworked the handling of station id callsigns.
In addition to some bugfixes and style/comment changes, this eliminates all code for special handling of CQ as a station id. Prior code relating to CQ was of limited utility and use. Current tests for valid callsigns allow any 2-character callsign. So, CQ can still be used if desired. A user should not use CQ for MYCALL or MYAUX, but using CQ is no worse than using any other illegal callsign. So, special tests to prevent this are not needed. No code exists or probably has existed to allow appropriate automatic response to a Connect Request to CQ. See a related discussion of CQ at the ardop users group:
https://ardop.groups.io/g/users/topic/use_of_cq_with_ardop/108851759
This pull request also fixes a deficiency from PR #93 which reworked the handling of grid square locators. This fix modifies locator_validate_grid() so that if an invalid grid is found, it is written to the debug log. This may be useful for debugging purposes if a frame containing an invalid grid is decoded.
A few adjustments to followup PR #79 which reworked the handling of station id callsigns.
In addition to some bugfixes and style/comment changes, this eliminates all code for special handling of CQ as a station id. Prior code relating to CQ was of limited utility and use. Current tests for valid callsigns allow any 2-character callsign. So, CQ can still be used if desired. A user should not use CQ for MYCALL or MYAUX, but using CQ is no worse than using any other illegal callsign. So, special tests to prevent this are not needed. No code exists or probably has existed to allow appropriate automatic response to a Connect Request to CQ. See a related discussion of CQ at the ardop users group: https://ardop.groups.io/g/users/topic/use_of_cq_with_ardop/108851759
This pull request also fixes a deficiency from PR #93 which reworked the handling of grid square locators. This fix modifies locator_validate_grid() so that if an invalid grid is found, it is written to the debug log. This may be useful for debugging purposes if a frame containing an invalid grid is decoded.