search

pfletcherhill / Gandalf

Events application for the Yale community.
2 stars 0 forks source link

Comments and tests #66

Closed khannotations closed 11 years ago

khannotations commented 11 years ago

Been a while since a PR! I added and fixed up some tests, and started the commenting process.

For some reason, the User.create_from_directory doesn't work in testing...even when I do rails c test. Not sure why, can you check it out on your computer?

We also have guard, now, so all you have to do is open a tab, run guard and all the tests will be run automatically when you change files...not sure if you're clunker of a computer can handle that though ;)

I also updated all the routes to 'get' or 'post', as appropriate, instead of 'match' (for security).

Hope the beach is fun!

pfletcherhill commented 11 years ago

Not sure guard is necessary, at least as a continuous testing mechanism. We should be writing tests, writing code, then testing, I think.

pfletcherhill commented 11 years ago

The excel spreadsheet of students should be included in .gitignore, right? I think we should also keep it in /lib.

pfletcherhill commented 11 years ago

All right, sweet. I'm confused about what happened with all the public assets. It looks like a bunch of them have duplicates, one of which has some string appended to it. Can you make sure everything we're putting in assets is necessary, and remove duplicates when possible. We can do the same with fonts -- we only need Helvetica Neue accessible. Generally, I'm not sure we need to store comments for who wrote each file, just what the functions do. Anyway, good job. Our code is going to be wining beauty contests before we are.

khannotations commented 11 years ago

Thanks for the awesome review. look it over again before you merge.

I removed fonts, as well as all those duplicate assets (i did rake assets:precompile once, which is why they were there). i left public/uploads/tmp since all that is already in our monstrous repo haha.