Closed khannotations closed 10 years ago
This is slick work dude.
As for the date format functions/utilities file, I'd suggest just making a file called utilities.js.coffee
in our app/assets/javascripts
folder. We can require it before backbone, and it'll then be accessible everywhere in our js. Putting it in a model seems hacky.
I'll pull your changes (probably tonight) and link up the backend and frontend very soon.
Will also check out your interface tonight.
Great, thanks for the comments. did you compare rafi and master? if you get too frustrated at work, you should for a quick laugh. i'll make the changes monday.
Not quite done yet, but wanted you to start the code review.
Some notes:
gandalf.js.coffee
should really go into a utility class somewhere. i was thinking of making aGandalf.Utilities
along with Models, Views, etc...and then we can just make a file and have an ordinary class with a bunch of methods in it. wanted to run that by you before chugging on.Events.create_some_upcoming_events
should be of assistance :)also...i kinda fucked up. if you look at the rafi branch, it says its "410 commits ahead and 406 commits behind master"...because i haven't merged in a hella long time haha. if you do a comparison between rafi and master, it's kinda funny actually. but after this PR goes through, I'll take on the behemoth task of merging rafi into master, and basically accepting all the things in master. which might lead to performance differences...uh oh. anyway, my bad on that. :)