search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

Provide better documentation for `getComps()` #116

Closed kellijohnson-NOAA closed 1 year ago

kellijohnson-NOAA commented 1 year ago

Moral of the story is that users need to specify weightid if they are aggregating age data otherwise the input sample sizes will be based on the number of length samples not age samples because the default is weightid = "Final_Sample_Size_L". @iantaylor-NOAA I checked you as a reviewer just to see if you can give the new documentation of getComps a glance.

iantaylor-NOAA commented 1 year ago

Thanks for getting this done. I'll review this afternoon.

kellijohnson-NOAA commented 1 year ago

Thanks @iantaylor-NOAA for the review and for finding the :bug: in the first place.