search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

install error related to "reshape" #24

Closed iantaylor-NOAA closed 3 years ago

iantaylor-NOAA commented 3 years ago

I had a there is no package called 'reshape' error installing PacFIN.Utilities. I think this line https://github.com/nwfsc-assess/PacFIN.Utilities/blob/master/R/plotStrat.R#L13 causes the package to be dependent on the reshape package (which exists on CRAN but I didn't have it installed). However, looking at the code below, it appears from https://github.com/nwfsc-assess/PacFIN.Utilities/blob/master/R/plotStrat.R#L36 that a function called reshape() is what is needed, not the reshape package. If so, I think line 13 could be changed from

@import stats reshape

to

@importFrom stats reshape
iantaylor-NOAA commented 3 years ago

This issue was resolved in commit 91c5ecd59a983b434d3d64d9bf6c53a270e97e2e by @kellijohnson-NOAA. The commit message notes that "many more functions need to be changed" to use :: instead of import.