search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

Sample table branch: minor function modifications #26

Closed chantelwetzel-noaa closed 3 years ago

chantelwetzel-noaa commented 3 years ago

This branch has a handful of random changes:

getExpansion_2

  1. Add new input to the getExpansion_2 function for Units and deprecate the Convert input. I did a match.arg here based on @kellijohnson-NOAA suggest, but I don't think I quite did it as envisioned. Please check and revise as needed. I will review any modification for future understanding.
  2. Correct the check for gear/state/strata/year check for missing catch data for expansion (#0e3878b616e7caf0fb4468c9445cfb70aed2f52b).

writeComps

  1. Add a "inputN" column to the csv files created by writeComps where the inputN is calculated by the Stewart method (see Pacific Ocean Perch 2017 assessment page 10 for details) (#2dbadcef0f91798d647f21c579adee1b7fd96a6c).
  2. Correction to deal with situations where the samples are all from one sex (#7bdea78e55c5b5790d49a19654aa04b0152ea5da).

createSampleTable function

  1. Add this function which can output samples of tows and fish often presented in West Coast groundfish assessments (#9a2e04412b6bacd6e0969bbcc5ecbd05aa3376bf).
kellijohnson-NOAA commented 3 years ago

Thanks @chantelwetzel-noaa for these changes. Once you give me the green light I can merge this into master.

chantelwetzel-noaa commented 3 years ago

@kellijohnson-NOAA Looks good. Thank you for being so thorough on this.