search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

Remove Puget Sound data #33

Open chantelwetzel-noaa opened 3 years ago

chantelwetzel-noaa commented 3 years ago

Data from Puget Sound, catches and bds, should be filtered out during the data pulling process. One way to identify Puget Sound data is to examine the PSMFC_CATCH_AREA_CODE where 4A, 70, and _PS codes indicate Puget Sound records. I determined this by examining the bds fields and should be verified to work on the catch data as well.

kellijohnson-NOAA commented 1 year ago

@chantelwetzel-noaa I think we settled on a compromise for this in that we would provide the data but write more verbose checks in cleanPacFIN() right?

chantelwetzel-noaa commented 1 year ago

I don't recall but I think you have convinced me that people may want to see these data and having an approach to provide them in the pull will support this. If we do include them and then add verbose messages in cleanPacFIN(), I think there should also be some level of communication that these data are included in the full data prior to cleaning. I can foresee people doing data exploration where cleanPacFIN() is not used could result in us having to field questions about the data. Perhaps we add this type of information to the data request form?