search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

RWT_LBS not being converted via cleanColumns function #47

Closed chantelwetzel-noaa closed 3 years ago

chantelwetzel-noaa commented 3 years ago

https://github.com/nwfsc-assess/PacFIN.Utilities/blob/562be10030cc252fc8bbf8ce2b9b7833f6a9e191/R/cleanColumns.R#L94

The WEIGHT_OF_LANDING_LBS in the new bds pull is listed to be converted to both lwt_lbs and RWT_LB. However, in the match function the column name is only converted for the first listing. I have added a workaround in the dover branch but there is likely a better way to fix this.

kellijohnson-NOAA commented 3 years ago

@chantelwetzel-noaa we fixed this right in the comps branch? If yes, can you close this issue. Otherwise, I will search for a solution.