search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

Weight units not updated after cleaning #56

Closed brianlangseth-NOAA closed 3 years ago

brianlangseth-NOAA commented 3 years ago

I see the unfiltered data has FISH_WEIGHT in grams, and values are as expected (in the 1000s). However after cleaning using cleanPacFIN, FISH_WEIGHT is converted to kgs, but the units in FISH_WEIGHT_UNITS still report "G". Easy to see they are obviously not in grams but still useful to correct as its likely to cause confusion.

kellijohnson-NOAA commented 3 years ago

Good point @brianlangseth-NOAA we should probably just move the calculated weight to weight_kg and leave the other columns as is. What do you think about that?

brianlangseth-NOAA commented 3 years ago

Probably the most intuitive way, much like lengthcm. I like it.

kellijohnson-NOAA commented 3 years ago

@brianlangseth-NOAA I haven't forgotten about this, just ran into other stuff while trying to clean it up. I will fix it soon though. Please let me know if you have a timeline that you need that is faster than the end of the week?

brianlangseth-NOAA commented 3 years ago

Thanks @kellijohnson-NOAA . There is no timeline for me. I ignore the weight units and just treat the weight as KG. Its all clearly in KG anyway.