pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 2 forks source link

Research Removals #62

Closed chantelwetzel-noaa closed 3 years ago

chantelwetzel-noaa commented 3 years ago

https://github.com/nwfsc-assess/PacFIN.Utilities/blob/bf73156dd653ae720f0afc7e96b6947328e281e2/R/PullCatch.PacFIN.R#L74

Just glancing at this line of code it looks like we are removing research catches? Is that correct? I would argue that these should be included in any pull we provide. Even though they are often negligible, we should still be accounting for this source of mortality. For Dover sole, there is a single year of ~300 mt or research catch for a single year so it was important to include these removals.

kellijohnson-NOAA commented 3 years ago

No ... data.woR isn't carried forward to anything; instead, data is returned.

chantelwetzel-noaa commented 3 years ago

Thank you for the confirmation! I did not have time this morning to walk through the code to understand this for myself.