search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

Is r cmd check needed? #77

Closed k-doering-NOAA closed 1 year ago

k-doering-NOAA commented 2 years ago

Is your feature request related to a problem? Please describe. I'm curious if it would be helpful to set up r cmd check on github actions for this or other pkgs in nwfsc-assess? I think it would be helpful if there are upstream dependencies that the pkg can easily become out of date with or if there are often install problems when people start trying to use pkgs again (e.g., at the start of a new assessment cycle)

Describe the solution you'd like The easiest way to set it up would be either by using ghactions4r::use_r_cmd_check or usethis::use_github_action_check_standard

I would be happy to show the setup of either or both in one of the nwfsc office hrs, if it seems helpful!

Describe alternatives you've considered It may be not necessary if the problems described are not of concern.

Additional context Add any other context or screenshots about the feature request here.

kellijohnson-NOAA commented 1 year ago

Thanks @k-doering-NOAA for mentioning this. It is currently failing but I am going to set them up anyway 😉