search

pfmc-assessments / PacFIN.Utilities

R code to manipulate data from the PacFIN database for assessments
http://pfmc-assessments.github.io/PacFIN.Utilities
Other
7 stars 1 forks source link

cleanPacFIN encountering error #81

Closed brianlangseth-NOAA closed 1 year ago

brianlangseth-NOAA commented 1 year ago

Describe the bug I cannot run cleanPacFIN. Gear groupings and state labels are fine. Error hits when trying to figure out SEX

Error in nwfscSurvey::codify_sex(data.vector = Pdata[, "SEX"]) : unused argument (data.vector = Pdata[, "SEX"])

To Reproduce Steps to reproduce the behavior:

  1. load PacFIN bds file
  2. run cleanPacFIN(loaded file....)
  3. Error is as below

Expected behavior I expect it to run and not get hung up

Screenshots image

Desktop (please complete the following information):

chantelwetzel-noaa commented 1 year ago

I was unable to recreate this error on my machine using the canary bds data. Can you update the nwfscSurvey package from github and see if that resolves the issue?

brianlangseth-NOAA commented 1 year ago

My version of the nwfscSurvey package had the same SHA1 code as the current one so that did not appear to be the issue.

I reinstalled PacFIN.Utilities incorporating a new change (commit a30e33d) and the script runs and works as expected. Thank you @chantelwetzel-noaa and @kellijohnson-NOAA.

kellijohnson-NOAA commented 1 year ago

Thanks for checking @brianlangseth-NOAA and sorry for the :bug: in the first place.