search

pfmc-assessments / VASTWestCoast

VAST for the NWFSC West Coast data
Other
5 stars 1 forks source link

Plot biomass index #39

Closed chantelwetzel-noaa closed 2 years ago

chantelwetzel-noaa commented 2 years ago

A few updates were needed to align with the latest version of VAST. The branch fixed the following items:

  1. Correct names and function arguments to read and create index plots
  2. Added the specifications for the tweedie distribution in the summary_nwfsc function
  3. Modified the ss_plot function to use red for CA, purple for OR, and blue for WA in order to align better with temperature gradients along the West Coast.
kellijohnson-NOAA commented 2 years ago

Thanks @chantelwetzel-noaa for these edits! Super helpful. I peaked at some of them yesterday so I have an initial question ... do we care that these are breaking changes and now the plotting won't work with older saved output?

chantelwetzel-noaa commented 2 years ago

That is a great question and was going to leave it up to you decide. I created the pull request to ensure that you saw these changes and did not go through the work to figure out them on your own. Personally, I suspect the frequency of people wanting to replot old runs is fairly low.

kellijohnson-NOAA commented 2 years ago

Yeah, I do not want to open any old runs that is for sure. And, if we were too open an old run, I am guessing that the csv of model output is going to be the only thing that is of real interest.

kellijohnson-NOAA commented 2 years ago

I have partitioned out of the required changes into individual commits along with some other needed changes in the branch fix_2022update. Can you create a single commit on the master branch or in a new branch (with a pull request) for the color changes? Then we can just close this pull request?

chantelwetzel-noaa commented 2 years ago

As always, I am not sure if I followed instructions correctly (I am a git problem). I made a color change commit to the new "fix_2022update" branch. After re-reading your instructions again, I don't think this is exactly what you were looking for, but hopefully the way I did it was ok. I am going to now close this pull request.

kellijohnson-NOAA commented 2 years ago

No worries @chantelwetzel-noaa committing to the fix_2022update is just fine. I am also going to delete the plot_biomass_index branch now.