pfmc-assessments / canary_2023

Other
5 stars 1 forks source link

Incorporate data and change setup for model runs #62

Closed brianlangseth-NOAA closed 12 months ago

brianlangseth-NOAA commented 1 year ago

Skeleton of model running file is up per commit 916b337. We need to incorporate new data from the 2015 base and then update new settings to match current best practices and our planned approach. @okenk check off the following once it is incorporated into the set up for this cycle

Data

Parameterizations and Biology

My suggestion is to keep the variance adjusts and lambda setups the same as was used for the 2015 model until we confirm our new settings and data run. Then from there we revisit these.

okenk commented 1 year ago

Is fecundity different? It looks like Jim also used E.J.'s dissertation which is the default, right?

brianlangseth-NOAA commented 1 year ago

Yes that is the default. Ive used eggs in the past, and I think the 2015 was linear instead. I planned to look over the options, which may just be confirming the same.

okenk commented 1 year ago

I am going through adding the age comps. I noticed some of them have very few samples and we might considering excluding them. Ones I flagged are:

Eliminating CA ASHOP would eliminate a figure panel that will likely have poor fits and low sample sizes, and could be distracting. Also there are so many fleets -> so many panels...

okenk commented 1 year ago

One other thing-- if we stick with separate ageing error for CAPS, ODFW, and WDFW, that information will need to be added to the age comps.

I think I finally have the double reads formatted correctly, but the max gradient is ~0.5 so something is amiss.

brianlangseth-NOAA commented 1 year ago

Confirmed on ageing error, those will be to be added to the comps.

I think I forgot to say but our moving of recent CA ASHOP catches to Oregon removes all CA length and age comps thus those wont appear anymore.

brianlangseth-NOAA commented 12 months ago

We have incorporated these (removed sparse comps, used past (from 2015 assessment) ageing error matrix, past assessment used EJ's dissertation but the updated 2017 paper updates that)