search

pfmc-assessments / canary_2023

Other
5 stars 1 forks source link

fix(53figures): Uses sa4ss::add_figure #82

Closed kellijohnson-NOAA closed 7 months ago

kellijohnson-NOAA commented 7 months ago

Used regex to change all html inclusion of figures to use sa4ss::add_figure(). Also adds full stops to the end of alternative text, changes all percent signs to be the word percent, and uses LaTeX math mode for subscripts rather than using ~.

This file was not checked for compiling.

kellijohnson-NOAA commented 7 months ago

I probably did not need to change the way that the subscripts were written. I can change them back if you would like?

brianlangseth-NOAA commented 7 months ago

Do I also need to change hyphens in labels to underscores?

brianlangseth-NOAA commented 7 months ago

Solutions to these include:

  1. Will have to adjust width to ensure no overlap of page numbers
  2. Can you glue::glue("I like {spp}") or paste("I like", spp)
  3. Kelli's suggestion was to not use underscores. The solution here was that for our html we had "fig:" in some of the labels. When those are removed the labels with hyphens worked.