search

pfmc-assessments / indexwc

Estimate indices of abundance for west coast fish species
2 stars 1 forks source link

[Feature]: deprecate `run()` #23

Open kellijohnson-NOAA opened 7 months ago

kellijohnson-NOAA commented 7 months ago

Describe the problem your feature request is related to.

Model features are too complicated to use a sweet of settings for a massive amount of species. So, instead I have found that a csv file that stores the configurations for each species is a better way forward. Thus, run() which takes a data frame of combinations of survey and species and "splits" them before calling run_sdmtmb() is no longer needed because the latter function is sufficient.

Describe the solution you'd like

Soft deprecate the function at first and then hard deprecate with suggested purrr::map() after dplyr::split() to show users how to use run_sdmtmb().

Describe alternatives you have considered

Keep the function ☹️

Additional context

No response

kellijohnson-NOAA commented 5 months ago

Started the process in 6c16f68 but @chantelwetzel-noaa can you confirm that you are no longer using the run() function and instead are using run_sdmtmb() in your current scripts?

chantelwetzel-noaa commented 5 months ago

Thank you for checking. Deprecate away!