[BUG]: too many GitHub package dependencies leads to API rate limit exceeded

kellijohnson-NOAA commented 1 year ago

Is there an existing issue for this?

[X] I have searched the existing issues

Current Behavior

Installing {indexwc} on a fairly new machine leads to too many packages being installed and

API rate limit exceeded

Expected Behavior

The package would have loaded seamlessly after using load_all() or remotes::install_github().

Steps To Reproduce

No response

Environment

- OS: Windows
- Node:
- npm:

Anything else?

I think eliminating the need for {VASTWestCoast} would help this a lot. @chantelwetzel-noaa if we need to do comparisons would it be alright to set those up in {VASTWestCoast} rather than here?

seananderson commented 1 year ago

Obviously good to limit the number of packages that need to be installed, but you can likely fix this by setting a GitHub PAT. https://github.com/r-lib/remotes/issues/210#issuecomment-430643547 which is a good idea anyways.

chantelwetzel-noaa commented 1 year ago

@seananderson Thank you for the suggestion. I will look into it. @kellijohnson-NOAA I added this dependency since I was user a handful of helper functions in {VASTWestCoast} (e.g., convert_strata4vast, get_inputgrid, ...). However, since the long-term plan is for this package to subsume {VASTWestCoast}, I think we pair this down by moving over some function being currently used from {VASTWestCoast} to this package or within the {nwfscSurvey} where appropriate.

pfmc-assessments / indexwc