pfmc-assessments / sa4ss

Generate a stock assessment document from Stock Synthesis output
https://pfmc-assessments.github.io/sa4ss/
Other
12 stars 7 forks source link

default text: save in functions rather than in templates #56

Closed kellijohnson-NOAA closed 1 year ago

kellijohnson-NOAA commented 3 years ago

Problem

Default text, such as that here, https://github.com/nwfsc-assess/sa4ss/blob/4998bf06b1e132fda382acd62dd3804ad58f1e9c/inst/rmarkdown/templates/sa/skeleton/20data.Rmd#L3-L21 is not

Proposed solution

Write text in a function and call that function in the template.

Potential problems

Not sure if a function is the best option or if we should just have child documents that are available in inst or somewhere else and call those child documents from the package rather than from the individual folders.

kellijohnson-NOAA commented 1 year ago

Closing b/c I am not entirely sure if this is better than what we currently have and there is no reason to change it.