pfmc-assessments / sa4ss

Generate a stock assessment document from Stock Synthesis output
https://pfmc-assessments.github.io/sa4ss/
Other
12 stars 7 forks source link

Soft deprecate `add_figure()` #64

Closed kellijohnson-NOAA closed 1 year ago

kellijohnson-NOAA commented 2 years ago

https://github.com/nwfsc-assess/sa4ss/blob/b8b66eb0964cd80ce40d4b9820123e0b4a93d728/R/add_figure.R#L55-L62

is no longer needed because {rmarkdown} has come a long way since 2020 when alternative text was not standard and could not be added via the code chunk options. Starting about April of 2021, {knitr} started allowing `fig.alt' as a chunk option (see the Rstudio blog post about it. So, add your figures however you desire, just be sure to include alternative text for those that need it. 🏆 for those in need of alternative text ♿.

kellijohnson-NOAA commented 1 year ago

I am no longer convinced that we don't need this. I have found a way to tag the document and use alternative text with the newest version of LaTeX but it requires extra text and some standard formatting. I am not sure if we will be able to do this in the .Rmd file as my only experience with a successful build is from the .tex file. We might have to use grep or sed to alter the built .tex file.

kellijohnson-NOAA commented 1 year ago

Closing this issue because it might be easier to know that all figures are imported in a standard way to keep up with the latest changes of LaTeX.