search

pfmoore / editables

MIT License
39 stars 11 forks source link

Add missing tox env checks to Github checks (and fix failures) #2

Closed gaborbernat closed 4 years ago

gaborbernat commented 4 years ago

Add the lint tox environment as Github action test via https://github.com/pre-commit/action

gaborbernat commented 4 years ago

@pfmoore I'm done now. All checks run and pass. I'll do the coverage tracking for the install hook once this gets in.

gaborbernat commented 4 years ago

@pfmoore addressed your requests, is now ok?

pfmoore commented 4 years ago

I'm going to accept these changes in the interests of moving forwards. However, at this point I want to stop looking at the project infrastructure and focus on the actual code, so for the immediate future I won't be accepting any more project infrastructure changes. I may make infrastructure changes myself (one I'm aware of is the coverage of the template) but I'd prefer to do those myself rather than accept PRs for them.