Remove brittle argument parsing reflection

pfn / kotlin-plugin

Build kotlin code using sbt

MIT License

136 stars 35 forks source link

Remove brittle argument parsing reflection #16

Closed Sineaggi closed 7 years ago

Sineaggi commented 7 years ago

Not sure if this is how you want to fix newer kotline versions, but here's a quick hack getting it to work. FYI this commit removes the Args class in favor of a built in argument parser. We could try to look for that class but I think that's headed down the wrong path.

pfn commented 7 years ago

I appreciate the PR. Some questions:

How backward compatible is this change?
Does it require a min kotlin version?

If the answer to either is "not very compatible, or requires a very new/EAP version" -- I would prefer to keep the existing Args lookup, and fallback to this workaround/use-of-internal Args parser when the method is present.

Thanks!

Sineaggi commented 7 years ago

I should have mentioned in my PR but...

It works with the currently set kotlin version and future versions
It shouldn't require a min kotlin version

Though I guess I'm not sure what the argument parsing was doing in the first place.

pfn commented 7 years ago

The use of Args predated kotlin switching to do it internally. But if you say this works on the current default version set (1.1.2)--good enough for me. Thanks

pfn commented 7 years ago

Coming back to this PR, it breaks all argument parsing altogether... odd, I thought I had travis hooked up to this project...

Sineaggi commented 7 years ago

Oh wow, thanks for coming back to this. I didn't notice during testing.