pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
905 stars 185 forks source link

chromeipass save credentials does not work for me #244

Open hokeson opened 10 years ago

hokeson commented 10 years ago

Hi, I am using chromeIPass 2.6.6 Keepass 2.24 KeePassHttp 1.8.3.0

there is no reaction of the application after i click on Save credentials in the ChromeIPass context menu. is there a way how to test it. no new entry apears :(

thx

pfn commented 10 years ago

Assuming everything is connected fine, it should appear in the keepasshttp passwords folder

Sent from my phone On Jan 24, 2014 8:06 AM, "hokeson" notifications@github.com wrote:

Hi, I am using chromeIPass 2.6.6 Keepass 2.24 KeePassHttp 1.8.3.0

there is no reaction of the application after i click on Save credentials in the ChromeIPass context menu. is there a way how to test it. no new entry apears :(

thx

— Reply to this email directly or view it on GitHubhttps://github.com/pfn/passifox/issues/244 .

hokeson commented 10 years ago

i think it is connected fine. while it fills passwords as they are saved but if i want to save a new one then it happends nothing. even a new entry in Keepasshttp passwords folder :( any other advice?

pfn commented 10 years ago

As far as i can recall in the code, any new entries saved should go into "KeePassHttp Passwords" folder; but there is no auto-save, if you close your database without saving and then reopen, you will not see it unless you save manually.

I chose not to enable auto-save to prevent any issues of database corruption if the user is modifying their database and don't intend to save their changes.

Do password updates take effect properly? If you say generation doesn't work, presumably, updating passwords should not work as well.

What do you see in the background page console for chromeipass? chrome://extensions

On Fri, Jan 24, 2014 at 7:47 PM, hokeson notifications@github.com wrote:

i think it is connected fine. while it fills passwords as they are saved but if i want to save a new one then it happends nothing. even a new entry in Keepasshttp passwords folder :( any other advice?

— Reply to this email directly or view it on GitHubhttps://github.com/pfn/passifox/issues/244#issuecomment-33280308 .

hokeson commented 10 years ago

the auto save is not the problem. but nothing does appear in "KeePassHttp Passwords" folder after I hit on filled password field with right mouse click on ChromeIPass Save credentials.

could it be by this failure in background page console? but i am not able to replicate the error. Failed to load resource: the server responded with a status of 503 (Service Unavailable) http://localhost:19455/ Error: 503 keepass.js:314 KeePass database is not opened keepass.js:317

I also get on some pages the error message "could not detect changed credentials"

but still no update in "KeePassHttp Passwords" folder :(

pfn commented 10 years ago

Reproduce this while looking at the background page.

503 database not opened means you need to unlock your keepass.

On Sat, Jan 25, 2014 at 3:13 PM, hokeson notifications@github.com wrote:

the auto save is not the problem. but nothing does appear in "KeePassHttp Passwords" folder after I hit on filled password field with right mouse click on ChromeIPass Save credentials.

could it be by this failure in background page console? but i am not able to replicate the error. Failed to load resource: the server responded with a status of 503 (Service Unavailable) http://localhost:19455/ Error: 503 keepass.js:314 KeePass database is not opened keepass.js:317

I also get on some pages the error message "could not detect changed credentials"

but still no update in "KeePassHttp Passwords" folder :(

— Reply to this email directly or view it on GitHubhttps://github.com/pfn/passifox/issues/244#issuecomment-33303682 .

hokeson commented 10 years ago

With the error 503 keepass.js:314 I found out, that i am not able to reporduce it while the database is unlocked. the error appears only when the db is locked. this is understandable. but still now new entry after Save Credentials while db is unlocked :(

pfn commented 10 years ago

No messages in console? What is the site you are trying

Sent from my tablet On Jan 26, 2014 1:11 AM, "hokeson" notifications@github.com wrote:

With the error 503 keepass.js:314 I found out, that i am not able to reporduce it while the database is unlocked. the error appears only when the db is locked. this is understandable. but still now new entry after Save Credentials while db is unlocked :(

— Reply to this email directly or view it on GitHubhttps://github.com/pfn/passifox/issues/244#issuecomment-33312610 .

hokeson commented 10 years ago

i checked the console but no message appeared. i tested today on facebook. i have no entry in kdbx for facebook. I unlocked the database. first i logged off from facebook. i filled in the upper row user name and password and tried to save credentials. no new entry in KeePassHttp Password folder, no message in extension console. so i created new entry in internet folder for facebook. i reloaded the facebook page and got a message to allow or deny filling of credentials. after allowing username and password were filled.

next what i tried was to change password on facebook pages. after filling old password and twice new password i used right mouse click on one of these passwords and then ChromeIPass instead of usuall 4 rows, 12 rows appeared. i clicked save credentials but again console nothing, no new entry in KeePass,no update to hand made facebook entry. I am really clueless :(

pfn commented 10 years ago

I guess I have no answer for you right now.

I'm particularly busy at the moment with a bunch of other projects, it'll probably be about a month before I can get back to maintaining chromeipass.

For now, I guess you'll have to work around this by adding entries into keepass manually :-/

On Mon, Jan 27, 2014 at 12:57 AM, hokeson notifications@github.com wrote:

i checked the console but no message appeared. i tested today on facebook. i have no entry in kdbx for facebook. I unlocked the database. first i logged off from facebook. i filled in the upper row user name and password and tried to save credentials. no new entry in KeePassHttp Password folder, no message in extension console. so i created new entry in internet folder for facebook. i reloaded the facebook page and got a message to allow or deny filling of credentials. after allowing username and password were filled.

next what i tried was to change password on facebook pages. after filling old password and twice new password i used right mouse click on one of these passwords and then ChromeIPass instead of usuall 4 rows, 12 rows appeared. i clicked save credentials but again console nothing, no new entry in KeePass,no update to hand made facebook entry. I am really clueless :(

— Reply to this email directly or view it on GitHubhttps://github.com/pfn/passifox/issues/244#issuecomment-33350320 .

ldormoy commented 10 years ago

Hi,

I have the same issue. I can retrieve stored passwords, but saving new passwords will result in having them saved in the Chrome password manager instead of in the Keepass database.

On the same system, Firefox + PassIFox works fine, I can normally save new credentials in the Keepass DB.

Please please fix it if you can, I really prefer to use Chrome and this is wonderful plugin makes my admin life so much easier !

ChromeIPass: 2.6.7 PassIFox: 1.1.10 KeePass: 2.25 KeePassHttp: 2.21.0.0 (KeepassHttp.plgx) OS: Ubuntu 14.04 Chrome: 35.0.1916.153 Firefox: 30.0

wolandtel commented 9 years ago

Same problem: chrome doesn't suggest to save password if it's native password database disabled. Else it simple saves passwords in own database.

kshivner commented 9 years ago

Same problem and there is no keypass http folder the top folder has the keypass http information in it but none of the saved credentials are in there I even sync the database in case it was saved to the database and did not show up in the ui yet

wtfrank commented 9 years ago

I have this problem as well. chromeipass will read passwords out of keepass but it will not add them to the keepasshttp passwords folder

aairey commented 8 years ago

+1

Deedasmi commented 8 years ago

+1

EDIT: Create a new password, log out of the website (if it auto-login), log in to website with new password, then click icon and it will offer to save it as a new password or update a previous one. It doesn't do it on generation.

wolandtel commented 8 years ago

Btw, it's very inconvinient interface implementation for me. syndaemon blocks tapping on touchpad for 2 seconds (in my configuration) after last key pressed to exclude accidental touching during typing. So, I not always have time to press ChromeIPass blinking icon.

madhatter commented 8 years ago

+1 I have the same problems. I can retrieve passwords from keepass for logins, but I am not able to save any new credentials via chromeipass to keepass. The icon is blinking but nothing happens. I don't see any error messages in the console. And there are no messages visible in keepass. But I remember that it worked once. There older entires in 'KeePassHttp Passwords'. Of course I could enter everything manually in keepass, but it would be nice to have them saved automatically...

KeePass 2.30 KeePassHttp 1.8.4 chromeIPass 2.6.8

madhatter commented 8 years ago

Additional information: I noticed that the popup does not show up when the icon is blinking. So that might be the reason that nothing gets saved (because I am not able to click on 'new' or 'updated'). I created a new keepass database and started from scratch. This seems to work as usual. I remember that I reconnected to the plugin to keepass before I noticed the problems. Maybe there is something wrong with the authentication in keepass. I tried to take a look, but found nothing helpful in the KeePassHttp Settings entry.

irwifi commented 7 years ago

[SOLVED] I had same problem. The password did not get saved on clicking "Save Credentials".

[SOLUTIONS] When "Save Credentials" is clicked, the toolbar icon of "ChromeIpass" turns to "RED" and starts blinking. On clicking the blinking icon, a popup appears just below the toolbar with 3 buttons - New, Update and Dismiss. Click on button "New". This will save the password.

madjo80 commented 7 years ago

When trying to log in on a site unknown in the KeePass database, the icon flashes red indeed, and when I click on it I get this screen: http://imgur.com/a/n3NTd

Note the empty fields for URL and username. Also clicking any of those three buttons doesn't do anything.

The screenshot was taking after I tried to add my Github account using ChromeIPass, but it's not limited to Github.

I can enter the URL and username+password combo to KeePass by hand, and then ChromeIPass will pick it up, but adding new entries to the database is sometimes impossible with the ChromeIPass extension. But sometimes it does work. (just now it prompted me to store a password (by blinking) and I was able to do so. Not sure what changed)

No such issues with PassIFox encountered, so far.

KeePass Version:2.30 chromeIPass Version:2.8.0 KeePassHttp Version:1.8.4.1 Windows 7

D3luxee commented 7 years ago

I got the same issue, i can confirm the behavior which @irwifi describes.

Keepass: 2.35 chromeIPass: 2.8.1 Chrome: Version 59.0.3071.86 KeePassHttp: 1.8.4.2

Windows 10 / 1703

I can use PassIFox without any issues.

CollinChaffin commented 7 years ago

This is frustrating because in my experience, this feature has NEVER ONCE WORKED in the many years I've (and now become clear everyone else in the world) been using Keepass with Chrome ON ANY ONE OF MANY SYSTEMS IN MANY ENVIRONMENTS. Never. Once. I have actually never seen ANY flow of data FROM Chrome back INTO Keepass - other than the original handshake setup for the browser<-->KeepassHTTP setup.

I've been a DEV myself for almost 30yrs and have tried every combination of settings and I see some supposed workarounds posted here now, but after doing a quick dig through the code I am simply not seeing the actual code that supposedly writes back to KeepassHTTP in Chrome for a new entry - I only see the gets not the sets. If I've missed it and someone is saying this works even with some hacky workarounds that means I've simply missed the code so let me know and if you happen to know which code supposedly handles the writing let me know I'll do a pull and post a proposed fix myself as I would absolutely love to have this feature finally work after waiting years.

Or, if I'm just mistaken and all of these users above have just not performed the operation correctly and it DOES work as stated, then I would ask that the authors of this "feature" (or anyone else that can demonstrate it working ) consider helping us out and recording a quick screencap of this feature working on any system in any environment - and also be sure to record your environment settings in the same video so we can all see what we are doing wrong.

Thanks for any help with this!

EDIT: @pfn I missed your comment above from half a DECADE ago that you were too busy but promised to get to this and clearly this is NOT fixed so to reiterate, I will be happy to do a pull to offer a fix but before I commit can you help by confirming for me where I can find the real foundation code that even ATTEMPTS to WRITE BACK to keepasshttp in chrome because I'm not seeing it and I just need to understand if it is really a "fix" or if this is/was really never coded on the Chrome side as I am beginning to suspect so instead of a "fix" we're looking at having to author the entire "new" feature from scratch on Chrome that works already in FF.

EDIT#2: Found the code responsible for this. It is in Handlers.cs the CreateEntry function not in this chrome plugin, but in the actual keepasshttp csharp code. Now, the key is how to debug why is doesn't work at all. I just even deleted and recreated my "KeePassHttp Passwords" group in keepass. Every other keepass and keepass-chrome function works perfectly and has for years - but just reran a new entry with newly recreated "KeePassHttp Passwords" group, no entry in the group it's like that call from the CreateEntry function just isn't being called properly. Any clues as to best way to debug into a csharp keepass plugin? That's a new one to me I do DEV in csharp but have not written or debugged a keepass plugin.

tinuzz commented 7 years ago

To add to the confusion, I'd like to say that for me it works... sometimes.

When I click on 'Save credentials', the icon starts blinking red. When I click it, sometimes I get the popup with the three buttons. When that happens, I can click 'New', and the password is saved in KeePass, in the 'KeePassHttp Passwords' folder. But most of the time, the popup does not appear, and the icon simply stops blinking when clicked.

I looked at the extension's background page console, but nothing is logged there when clicking the icon.

Cheers, Martijn.

shtrom commented 6 years ago

Similar issue here: everything is connected; password retrieval and generation work, but not saving credentials. The icon blinks, but nothing happens after I clicked on it, and the credentials are saved nowhere.

chromeIPass: 2.8.1 KeePassHttp:1.8.4.2 KeePassXC 2.2.2 ‎Chrome 62.0.3202.94 (Official Build) (32-bit) [from Portable Apps]