pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
908 stars 186 forks source link

Zotero conflicts with PassIFox and breaks WebDav Sync #317

Open raabf opened 9 years ago

raabf commented 9 years ago

Brief

If the Add-on called PasslFox is installed WebDav Sync will fail with Error "Please type in a password".

AddOn PassIFox

The AddOn will auto fill username/password forms in web pages. For that it must connect to the password manager KeePass. To do that the KeePass plugin KeePassHttp starts a web server on port 19455 to which the PassIFox Addon will connect.

Reproducing:

  1. The Add-on PasslFox (mozilla.org) must be installed and activated
  2. Zotero Addon must be installed and activated.
  3. Go to Zotero Preferences -> Sync
  4. Select in File Syncing -> My Library the Protocol WebDav
  5. Provide ...
    • any URL (must not be valid, but also tested with an working URL)
    • any user name (must not be valid, but also tested with an working username)
    • any password (must not be valid, but also tested with an working password)
  6. Click on Verify Server
  7. An Error will prompt with Please type in a password (so even if a password is set)

    Notes

It makes no difference if KeePass is running or not.

It will be directly working again after deactivating PassIFox in the Addon settings of Firefox.

The PassIFox addon works correct also if the Zotero Addon is activated.

Expected Behaviour

Zotero Reporting Bug ID: 972577535

The Messages above are translated myself from German, so they are maybe different from the original English language setting.

Link to Bug Report to the Zotero Developer

cornercase commented 8 years ago

I can confirm that this is still an issue.

Environment:

OS: OS X 10.8, 10.9, and 10.10 Firefox: every version from 33 to 40.0.3 KyPass Companion (including KeePassHTTP): 1.7

Observed Behavior:

In Zotero settings, I add a username and password to the WebDav settings. KyPass Companion opens a dialog box noting that Firefox is trying to add a user/password combination to the database. I allow the entry to be created. Then, when clicking verify, Zotero claims that user/password combo for WebDav is not working. It also seems to affect the Zotero sync username/password.

Attempted failed workaround:

I attempted to trick the system by saving the username/password combo to Passifox using the save prompt as previous noted. I then disabled Passifox, repeated the procedure to get the user/pass combo saved in the Firefox password manager. This also toggled a boolean flag that Zotero uses to check if the settings were saved correctly. I then reenabled Passifox and Zotero was unable to sync, claiming an invalid username/password combo.

Potential Zotero code reference:

https://github.com/zotero/zotero/blob/5fc2dd4d44bb226aa06517b67d66396e14b1f474/chrome/content/zotero/xpcom/storage/webdav.js#L702