pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
903 stars 185 forks source link

Fill username and password does not work but fill password does on some sites #33

Open BWMerlin opened 13 years ago

BWMerlin commented 13 years ago

I have a problem on some forums (I haven't paid attention to all of the sites but I know at least two of them are vbulletin boards and suspect the others are as well) where If I choose fill username and password and try and login, login fails because of bad username/password combo but if I choose fill password only or copy and paste my password from keepass login works and firefox requests if I want to update the stored password or not. If I choose yes I want to update the stored password and then logout and log back in the same problem occurs and I either have to get passifox to only do the password fill in (have tried with an without two-channel auto-type obfuscation) or copy paste my password.

I am using PassIFox 1.1.3, KeePass 2.15, KeePassHttp 1.0.3.8, Firefox 4.0.1 running on Windows Vista Ultimate 64 SP2.

pfn commented 13 years ago

This might be related to a bug that existed in chromeipass that I fixed but not in passifox.

If the fields do not belong to a form or they belong to different forms, the filling will fail.

I'll fix this when I get a chance to (day-job endeavors require my full attention until the middle of july), also please indicate what sites this is occurring on.

BWMerlin commented 13 years ago

I have had a little more of a look into my problem and if I close Firefox and KeePass (probably don't need to close KeePass) and then re-open both and try and login with fill username and password it works correctly but if I don't close Firefox I have to use fill password only otherwise it will not work and keeps asking for me to update my stored password.

I believe this is because when I initially logged in with my old username and password to get PassIFox to bring it into KeePass I ticked the remember box on the website. I then changed my password, logged out, tried to log back in by using fill username and password as well as selecting remember me on the website and the login would fail. If I do not tick the remember me box on the initial login and then go through my change password, logout and then log back in with fill username and password it works correctly.

However this is not always the case. On http://www.msfn.org/board/index.php even when I did not choose the tick box remember me, after I changed my password and logged out when I chose fill username and password the password field gets filled out. However if you click within the password field you can see the number of characters reduce from the amount that my password is to only half a dozen or so. If you don't click in the password field and just press sign in you can also notice that the password length gets chopped down. But if you click in the password field and select fill in password and then login everything is fine.

I have had problems on the following sites (probably related to choosing the remember me tick box on the site): http://www.wilderssecurity.com http://www.ynhub.org/forum/index.php http://www.dtvforum.info http://forum.ventrilo.com/

pfn commented 13 years ago

I think you have two entries in keepass with the same user name, delete the one with the wrong password.

BWMerlin reply@reply.github.com wrote:

I have had a little more of a look into my problem and if I close Firefox and KeePass (probably don't need to close KeePass) and then re-open both and try and login with fill username and password it works correctly but if I don't close Firefox I have to use fill password only otherwise it will not work and keeps asking for me to update my stored password.

I believe this is because when I initially logged in with my old username and password to get PassIFox to bring it into KeePass I ticked the remember box on the website. I then changed my password, logged out, tried to log back in by using fill username and password as well as selecting remember me on the website and the login would fail. If I do not tick the remember me box on the initial login and then go through my change password, logout and then log back in with fill username and password it works correctly.

However this is not always the case. On http://www.msfn.org/board/index.php even when I did not choose the tick box remember me, after I changed my password and logged out when I chose fill username and password the password field gets filled out. However if you click within the password field you can see the number of characters reduce from the amount that my password is to only half a dozen or so. If you don't click in the password field and just press sign in you can also notice that the password length gets chopped down. But if you click in the password field and select fill in password and then login everything is fine.

I have had problems on the following sites (probably related to choosing the remember me tick box on the site): http://www.wilderssecurity.com http://www.ynhub.org/forum/index.php http://www.dtvforum.info http://forum.ventrilo.com/

Reply to this email directly or view it on GitHub: https://github.com/pfn/passifox/issues/33#issuecomment-1395539

BWMerlin commented 13 years ago

pfn I only have the one entry that PassIFox creates in KeePass

pfn commented 13 years ago

I doubt it do a search in keepass for your user name, the password only gets changed if Firefox detects that there are multiple entries with the same user name for a given site. I have a similar problem with Google on my gmail and apps domain account.

BWMerlin reply@reply.github.com wrote:

pfn I only have the one entry that PassIFox creates in KeePass

Reply to this email directly or view it on GitHub: https://github.com/pfn/passifox/issues/33#issuecomment-1395631

BWMerlin commented 13 years ago

Prior to setting up PassIFox I imported all of my password from Firefox into KeePass using this (http://seo-website-designer.com/Firefox-KeePass-Password-Import) but none of them imported entries worked (that didn't bother me as long as a I had them so I knew which sites had my password so I could go and change it).

When I go to a site I want to change my password for, I first try and use the fill username and password option but that fails (I get a little notice bar saying no entries for this site). I then move my current none working entry out of the KeePassHttp Passwords group and into an archive group and then login to the site and get PassIFox to create a entry in KeePass.

Because my imported entries don't work and PassIFox creates a new entry and not over writes the current none working entry I assumed the PassIFox can only get usernames and passwords from the KeePassHttp Passwords group.

Going back over my old archived entries I can confirm that the sites that I had problems with an selected the update stored password option have not been updated (they still have their old passwords). I can also confirm that on those same sites the PassIFox entry is also not updated after selecting update stored entry (evident by the save change option being greyed out because no changes have been made to the KeePass database).

pfn commented 13 years ago

Set the option on your archive group to ignore searches, it appears to be interfering with the password searches.

BWMerlin reply@reply.github.com wrote:

Prior to setting up PassIFox I imported all of my password from Firefox into KeePass using this (http://seo-website-designer.com/Firefox-KeePass-Password-Import) but none of them imported entries worked (that didn't bother me as long as a I had them so I knew which sites had my password so I could go and change it).

When I go to a site I want to change my password for, I first try and use the fill username and password option but that fails (I get a little notice bar saying no entries for this site). I then move my current none working entry out of the KeePassHttp Passwords group and into an archive group and then login to the site and get PassIFox to create a entry in KeePass.

Because my imported entries don't work and PassIFox creates a new entry and not over writes the current none working entry I assumed the PassIFox can only get usernames and passwords from the KeePassHttp Passwords group.

Going back over my old archived entries I can confirm that the sites that I had problems with an selected the update stored password option have not been updated (they still have their old passwords). I can also confirm that on those same sites the PassIFox entry is also not updated after selecting update stored entry (evident by the save change option being greyed out because no changes have been made to the KeePass database).

Reply to this email directly or view it on GitHub: https://github.com/pfn/passifox/issues/33#issuecomment-1395657

BWMerlin commented 13 years ago

I have just set searches to disable on my archive group and still no luck. I just tried on the ubuntu forums and ran into the same problem.

I moved my ubuntu entry into my archive group and saved. I logged into the ubuntu forums and chose for Firefox to remember my username and password as well as having the forum remember me via the remember me tick box when signing in.

Once I was logged in I saved my KeePass database and went into change my password on the ubuntu forums. I had my KeePass ubuntu forum entry generate a new password using a password generation profile and saved the new password it made and then saved my KeePass database. I then used the fill in password option and filled in my new password in the new password and confirm new password field and then confirmed the changes to my ubuntu forums account.

When I pressed saved changes on the ubuntu forum I was prompted by Firefox if I would like to update my saved password with the new one I just entered and I declined (ignored the prompt till it went away). I then signed out of the ubuntu forums and tried to sign back in using fill in username and password and once again ticking the remember me box. login then failed.

I then entered in my username and the password field populated via saved information but I then right clicked in the password field and chose fill in password option as well as forum remember me and sign in was then successful.

pfn commented 13 years ago

1) passifox caches entry data for 30 seconds, so if you selected update entry and then let passifox fill automatically, then you may get stale data (this will be fixed in the next version of passifox I release--updates will flush the cache)

2) when firefox asks if you want to update the saved password, you should accept; passifox works by intercepting the builtin password manager and will update the keepass database if you select to update your entry. If you aren't selecting save, then keepass never gets your correct password. -- your passwords are never actually stored anywhere in your firefox profile even if you tell firefox to update your password entry.

BWMerlin commented 13 years ago

I shall try and wait over 30 seconds next time to test this out.

On point two KeePass should have the password as I generated the password using the entry that PassIFox put in there using the generate password button.

Either way I look forward to the next release.