Notification controls

[braincow]

I reported issue about the problem of constant "KeePass is not running" notifications popping up on my browser.

I have noticed that multiple people are opening duplicate issues on this same problem so I finally decided to implement simple "fix" for this feature. Now user can choose what messages are displayed by editing values through about:config. Also as a bonus the lifetime of a popup can be configured from the same config tree as well.

[HeyZiko]

Nice. I like how you've followed the patterns as originally set out. +1 for merging this PR. /cc @pfn

[heX16]

Very useful PR! Thanx! Waiting merge.

[dontspamm]

so this dint got merged ? @braincow can you start a fork, @pfn so far is ignoring this issue

[braincow]

@dontspamm I am considering it, but to be honest I do not really want to maintain a fork of this project as it would mean I would need to rename it and apply to Firefox plugin signing program etc necessary for it to be distributed. Still hoping @pfn would react in some way.

[Gary92]

Is this issue solved? The extension still shows me that notification.

[3ruce]

Yep... I manually changed

pref("extensions.passifox.notification.kpf-db-note", true);

to

pref("extensions.passifox.notification.kpf-db-note", false);

As outlined here https://github.com/pfn/passifox/blob/master/passifox/defaults/preferences/defaults.js

And that worked temporarily, but it would be great to see this incorporated into a new release...

[Gary92]

Great to read that, so let's hope for an update (and that it will be released soon).

[pfn]

You change it in about:config

On Thu, Jun 9, 2016, 4:11 AM Gerardo Considerato notifications@github.com wrote:

Great to read that, so let's hope for an update (and that it will be released soon).

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pfn/passifox/pull/449#issuecomment-224865407, or mute the thread https://github.com/notifications/unsubscribe/AAfQxSJy5gXRy_TyTxTcRYXB92_JT-_Aks5qJ_T3gaJpZM4G4o3f .

[Gary92]

I tried it now and I can confirm it works, however the "average" user expects to have an easy-editable option to enable or disable this feature without manually messing up configs. Consider also an option to show the notification once per session. So, again, I suggest you to implement such an option in your (really good and useful) extension in order to make it even better.

EDIT - Unfortunately, I have to correct my previous statement: I've changed that value in about:config, however the message still appears with some websites. I'll investigate further.

[pfn]

Development on these extensions is mostly inactive. Community pull requests are how this feature would be added.

On Fri, Jun 10, 2016, 3:05 AM Gerardo Considerato notifications@github.com wrote:

I tried it now and I can confirm it works, however the "average" user expects to have an easy-editable option to enable or disable this feature without manually messing up configs. Consider also an option to show the notification once per session. So, again, I suggest you to implement such an option in your (really good and useful) extension in order to make it even better.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/pfn/passifox/pull/449#issuecomment-225144366, or mute the thread https://github.com/notifications/unsubscribe/AAfQxbmjSlvjPdLMPaz-wNpQ2u-5AyQ6ks5qKTbbgaJpZM4G4o3f .

[3ruce]

Ok, btw, is there a roadmap/ideas for the future anywhere?

[radlerandi]

changing "extensions.passifox.notification.kpf-db-note" to false does not work in my browser, i still get this annoying "is not running" thing. Passifox 1.2.0, Palemoon 26.5.0 x64 on Linux Mint 18. :(

[braincow]

@radlerandi change the kpf-running-note to false. this prevents the popup from rising when you dont have keepass running. db-note pops up if you have keepass running but there is a problem on retrieving data from the database.

[radlerandi]

@braincow thanks! this solved the issue :)