pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
905 stars 185 forks source link

chromeIPass has an issue with High ANSI chars #473

Closed zeromido closed 8 years ago

zeromido commented 8 years ago

Hi, I've just found this issue chromeIPass saves passwords with High ANSI chars incorrectly e.g. this password: ¥µ¡²#ÎìÓ®±×èä¼ý-«`µý

is saved as: ����#��Ӯ�����-�`�� Please fix ASAP

Keepass 2.30 KeePassHttp 1.84 Chrome 49.0.2623.75 32bit chromeIPass 2.6.8 Edit: Issue was also repoted previously at https://github.com/pfn/passifox/issues/242

pfn commented 8 years ago

probably caused by #47

zeromido commented 8 years ago

@pfn Okay, Please fix. It costed me more than five logins and fortunately I recovered all of them except one.

pfn commented 8 years ago

probably not any time soon

On Wed, Mar 23, 2016 at 2:35 PM zeromido notifications@github.com wrote:

@pfn https://github.com/pfn Okay, are you going to fix that?

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pfn/passifox/issues/473#issuecomment-200552994

zeromido commented 8 years ago

@pfn Would you even tell me what's the cause to that error (Current code is totally different from the commit you mentioned) Edit: I'm a n00b!

pfn commented 8 years ago

I don't know what the cause is, I can reproduce it and determine that there is a bad conversion from latin1 to utf8

On Wed, Mar 23, 2016, 3:23 PM zeromido notifications@github.com wrote:

@pfn https://github.com/pfn Would you even tell me what's the cause to that error (Current code is totally different from the commit you mentioned)

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pfn/passifox/issues/473#issuecomment-200567120

zeromido commented 8 years ago

Fixed by https://github.com/pfn/passifox/pull/491

pfn commented 8 years ago

Does this mean you verified this fix with keepass?

On Sun, Apr 17, 2016, 12:50 PM zeromido notifications@github.com wrote:

Closed #473 https://github.com/pfn/passifox/issues/473.

— You are receiving this because you were mentioned.

Reply to this email directly or view it on GitHub https://github.com/pfn/passifox/issues/473#event-630492852

zeromido commented 8 years ago

@pfn Yes. I commented there see https://github.com/pfn/passifox/pull/491#issuecomment-211102984