search

pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
905 stars 185 forks source link

Broken functionality with Electrolysis enabled in Firefox #563

Open edifus opened 7 years ago

edifus commented 7 years ago

https://wiki.mozilla.org/Electrolysis

Electrolysis allows better performance and better security through tab isolation in the latest versions of Firefox. With this feature enabled, PassIFox behaves a little weird.

When I right click a username field select 'Fill User & Pass' it will only fill in the username. If I right click the password field and do the same, it will fill in the password; but the password no longer fills in at the same time as the username.

-I have disabled automatic filling in when there is only a single username found (for security reasons). -Disabling Electrolysis fixes the issue and the behavior returns to normal.

ibuk01 commented 7 years ago

+1

3ruce commented 7 years ago

+1

cloutierjo commented 7 years ago

+1

Mte90 commented 7 years ago

+1

simonbcn commented 7 years ago

Without e10s this addon is unusable for me. 😢

notNSANE commented 7 years ago

Subscribing to this thread to show my support for this change. Both this extension and Electrolysis are fundamental to my usage of Firefox.

I'll also add more documentation regarding this subject: https://developer.mozilla.org/en-US/Add-ons/Working_with_multiprocess_Firefox

callahad commented 7 years ago

With the upcoming deprecation of XUL-based add-ons, the easiest path is probably to just port ChromeIPass to Firefox as a WebExtension. I'd be very interested in knowing if it needs any APIs that we do not yet support.

Mte90 commented 7 years ago

The best way is to try the chrome version on firefox and see what happen

callahad commented 7 years ago

ChromeIPass definitely doesn't work out-of-the-box on Nightly, so we need something. Unfortunately, I'm heads-down on WebAssembly for the next two months, so I can't investigate directly.

projectgus commented 7 years ago

Ran into this a few days ago and I had a couple of hours free this evening, so I hacked up the beginnings of Firefox/Webextension support: https://github.com/projectgus/passifox

Basics seem to work - I can connect to Keepassxc, log in to sites (FF51, Linux). The Chromeipass options tab displays but I haven't checked if changing anything there works.

The changes are so far fairly pedestrian - things like changing chrome.extension.sendMessage(M, callback) to browser.runtime.sendMessage(M).then(callback). A good learning exercise for this WebExtensions newbie, though! I don't know whether these changes will break Chrome support or not.

Mte90 commented 7 years ago

As I know for chrome./browser. is the same and firefox support only the second one.

hyviquel commented 7 years ago

@projectgus Starting a pull request might be the best way to get help on this 😉