WebExtension (Firefox) compatibility for chromeIPass

[projectgus]

As discussed in #563. Allows Electrolysis (multi-process windows) feature to function in recent Firefox, and also provides a path for support once XUL-based addons are disabled in Firefox.

Support is not quite as tightly integrated as it was with passifox (ie there's no integration to Firefox's own "Fill Password" functions any more), but it seems very usable all the same.

Still a work in progress:

• [x] Changed all chrome.xxx APIs to use browser.. Some chrome APIs are implementated in Firefox and work as-is, but a few (such as chrome.extension.sendMessage() are not. Seemed cleaner to change them all over.
• [x] Add Mozilla's webextension-polyfill for Chrome compatibility for browser.xxx. Needed to cherry-pick some PRs before things came good (details in commit message). The basics seem to work.
• [x] Thoroughly test for broken Chrome functionality. I suspect there will still be some things which don't work.
• [x] Firefox doesn't support webRequest.onAuthRequired (yet?) so can't fill HTTP auth popups from Chromeipass. Need to at least re-enable for Chrome, and hide the relevant Settings on Firefox.
• [x] Haven't confirmed extension persistent storage (association to keypass, etc.) is working properly in FF. I think this is because I can only load the extension temporarily, so it's removing localStorage whenever I restart the browser. Firefox production builds don't allow unsigned addons at all any more, except temporarily.
• [x] Has a Chrome Web Store link in the Settings when running on Firefox
• [x] jQuery ("cIPJQ") seems to have some issues on FF that may be breaking functionality.
• [x] Detecting password fields for generation of new passwords doesn't yet work on FF, I think related to the jQuery errors but I'm not sure.
• [ ] Context menu access keys aren't supported (and the strings render verbatim) in FF. FF Bug.

Also, I don't know if this would be a good time to change the name? Or even if you're interested in adding this support at all - given it's a fairly major change to what seems like a stable Chrome extension.

[varjolintu]

I made a PR to projectgus/passifox#1 which solves an issue with HTTP auth with Chromium based browsers. It's not pretty but works as a workaround until there's a better solution.

[varjolintu]

@smorks Here's one solution to the problem with forms inside hidden divs. Simple but works. Tested with Firefox 55 and Chromium 61. If you know any better solution than setInterval, please let me know.

[projectgus]

Hmm. How about using MutationObserver to detect DOM changes? https://stackoverflow.com/a/11546242

May still need a timer to rate limit and avoid a notable performance impact (ie reset a ~100ms timer each time the DOM changes, so 100ms after the last DOM change event the extension scans for login boxes.)

EDIT: Actually, given you can filter the events you care about it may be possible to filter so you only get an event if a password field changes. I don't know if that would include the parent div's visibility changing, though.

BTW, @varjolintu, sorry I haven't looked at your other PR content yet. Plan to do so this weekend.

[varjolintu]

@projectgus I already closed the pull request. @smorks did a better job implementing the same fix :)

[hackel]

The recent release of Firefox 57.0b1 makes the WebExtension-compatible version of Passifox all that much more urgent! Thanks for your continued work on this.

Edit: Just signed and installed it myself and it is working great!

[aurelg]

@hackel For those of us not familiar with signing/installing manually, would you mind providing a short description of the required steps, or at least a link?

[craftycorvid]

Track this project for a WebExtension fork of passifox/chromeipass: https://github.com/smorks/keepasshttp-connector

[craftycorvid]

And now it's on AMO: https://addons.mozilla.org/en-US/firefox/addon/keepasshttp-connector/

[z3ntu]

Will passifox (on AMO) be updated to webextension in the future? Or will this "kepasshttp-connector" be the version to use on 57+?

[RealOrangeOne]

Firefox 57 has now been released, are there any plans to get this shipped soon? :shipit:

[dakra]

@RealOrangeOne Loot at the comment above from @Ivan0xFF. The firefox compatible fork is already on AMO: https://addons.mozilla.org/en-US/firefox/addon/keepasshttp-connector/

I'm using it every day and works great :)

[Ketrel]

Does it work with 52 ESR?

On November 14, 2017 7:17:05 PM EST, Daniel Kraus notifications@github.com wrote:

@RealOrangeOne Loot at the comment above from @Ivan0xFF. The firefox compatible fork is already on AMO: https://addons.mozilla.org/en-US/firefox/addon/keepasshttp-connector/

I'm using it every day and works great :)

-- You are receiving this because you are subscribed to this thread. Reply to this email directly or view it on GitHub: https://github.com/pfn/passifox/pull/595#issuecomment-344444250

-- Sent from my Android device with K-9 Mail. Please excuse my brevity.

[RealOrangeOne]

The fork works, but its the chrome version, which doesnt integrate nicely with the builtin password manager. Really hope that feature stays, assuming the WebExtension API exposes this

[rugk]

No that feature does not work. It is not yet exposed by the WebExtensions API.

[arpost1]

Is the KeePassHTTP Connector add-on safe for users to use? I'm new to KeePass and am hoping that some kind of fix for Firefox Quantum integration that is secure is available.

[varjolintu]

@esat7 It is safe.