pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
903 stars 185 forks source link

Basic Authentication crashes Firefox 52 #612

Closed Whoops closed 10 months ago

Whoops commented 7 years ago

Running Arch Linux, Firefox 52.0.1 64-bit, PassIFox 1.2.2, visiting any page that uses basic authentication immediately crashes Firefox before the dialog is shown. Everything works fine if PassIFox is disabled.

tlaerm commented 7 years ago

Seconded. Happens to me too. Firefox 52.0.1 (64-bit) Linux, PassIFox 1.2.2

Whoops commented 7 years ago

FYI, I've been using the WebExtension version provided in #595 with no issues since filing this bug.

mendel129 commented 7 years ago

same here, windows10 - firefox 52.0.2 64b - passifox 1.2.2

https://crash-stats.mozilla.com/report/index/f4f19a4e-1d10-4ebc-aeb8-9247d2170329

example website: https://mendelonline.be/glype/

wknd commented 7 years ago

Same on ubuntu 16.04, Firefox 52.0.2, PassIFox 1.2.2

ghost commented 7 years ago

Confirm this bug with macOS 10.12.4, Firefox 52.0.2 and Passifox 1.2.2

hockeymikey commented 7 years ago

PassIFox alone doesn't crash it basic prompts, only when paired with certain addons. I've found the following cause it:

Tested with WaterFox (54.0.3) and CyberFox (52.3.0)

michauk commented 7 years ago

My firefox suddendly crashed a few hours ago. I figured out my passifox plugin was involved. As jockeymikey mentionned, this is the combination betwwen plugins, I disabled ublock (which just upgraded to 1.13.10) and switched to this good ol' adblockplus because I'm in a hurry

davelit commented 7 years ago

I had the same problem. I have tested @smorks' chromeipass_firefox fork, which seems to work fine so far. The only caveat is that you need to re-pair it with KeePassHTTP every time you restart your browser, as it is currently not able to persist its configuration, including the pairing key. See Change from using localStorage to WebExtension storage API for saving prefs.

ghost commented 7 years ago

I can confirm this with Firefox 55.0.3 on MacOS with PasslFox 1.2.1 and uBlock 1.14.0. After I disable uBlock, the browser won't crash anymore.

zilon84 commented 7 years ago

Same here with FF 55.0.3 on Windows 10 with PassIFox and uBlock origin. If one of the addosn is not activated, FF does not crash.

davelit commented 7 years ago

Yeah, just install smorks' fork, version 2.8.5 or later: https://github.com/smorks/passifox/releases. It contains the fix for the pairing issue I mentioned yesterday and works great.

In addition to that you will want to disable Firefox' built-in password store, in order to not get confused by constant popups asking you to save your password: Set "Firefox/Tools > Options > Security > Remember logins for sites" to "off".

hockeymikey commented 6 years ago

A fix would be nice. Smorks' fork is a web extension version and is miles worse in featurability.

michauk commented 6 years ago

yes, it happened for me yesterday with adblock+ instead of ublock... and that fork isn't efficient as passifox bad times for firefox plugins.... I had to move to the latest firefox ESR version in order not to loose all my plugins with that new quantum. But still, this bug.... aaaaaaaaaaaaaah maybe time to move back to chrome.......

hockeymikey commented 6 years ago

@michau Chrome is still miles worse. I'd recommend Waterfox, Basilick, and Palemoon in that order.

michauk commented 6 years ago

I moved to quantum. I lost 2 hours but managed to find every plugin I needed (still tabmix+ missing, I'll do without until it's available). About keepass, I'm using "Keefox", it does the job. I had to adjust some things regarding URL wildcard (to handle subdomains authentication efficiently on a specific domain I have) + ublock origin. Regarding firegestures (another on I couldn't skip) => I discovered strokeplus which kind of solve the plugin problem entirely! take a look at it.

keefos has a nice behaviour to fill forms in + apache authentication

Regards