pfn / passifox

Extensions to allow Chrome and Firefox (4.0+) to auto form-fill passwords from KeePass (requires KeePassHttp)
GNU General Public License v3.0
908 stars 186 forks source link

Fix selector for 'id' to support semi-colons #669

Open gmcelhanon opened 6 years ago

gmcelhanon commented 6 years ago

The current preparedId function produces a jQuery selector that fails on ids containing a ;.

The failure I encountered was on an internal SSO page that was generating ids for controls using values like 34:2;a. ChromeIPass was generating errors in the console, and even though the prepareId function was escaping some characters, the semi-colon was not included in the set. Adding the semi-colon to the set of characters being escaped corrected the issue.