Fix type inference for dictionaries

pfnet-research / chainer-compiler

Experimental toolchain to compile and run Chainer models

MIT License

112 stars 23 forks source link

Fix type inference for dictionaries #818

Closed momohatt closed 4 years ago

momohatt commented 4 years ago

The inference results of a dictionary {'foo': 1, 'bar': None} has been {string : int} whereas it is expected to be {string : optional(int)}. This PR fixes such wrong behavior.

shinh commented 4 years ago

/test

pfn-ci-bot commented 4 years ago

Successfully created a job for commit 6acc432:

Dashboard for commit 6acc432

shinh commented 4 years ago

LGTM, thanks!!