Fix unify to prohibit upcasting of types

pfnet-research / chainer-compiler

Experimental toolchain to compile and run Chainer models

MIT License

112 stars 23 forks source link

Fix unify to prohibit upcasting of types #824

Closed momohatt closed 4 years ago

momohatt commented 4 years ago

This PR fixes the behavior of unify so that it only instantiates unassigned TyVars and doesn't try to infer the upcasting of types. As a result, some of the test cases in Primitive_test.py becomes untypeable.

Also, this PR makes list/dict types invariant by adding a subtyping check in join.

shinh commented 4 years ago

/test

pfn-ci-bot commented 4 years ago

Successfully created a job for commit 15a7a9d:

Dashboard for commit 15a7a9d