search

pfnet-research / gcp-workload-identity-federation-webhook

This webhook is for mutating pods that will require GCP Workload Identity Federation access from Kubernetes Cluster.
Apache License 2.0
43 stars 11 forks source link

Fix webhook server port #41

Closed ordovicia closed 9 months ago

ordovicia commented 9 months ago

28 introduced a bug that the webhook server listens on 944 port, not 9443.

https://github.com/pfnet-research/gcp-workload-identity-federation-webhook/pull/28/files#diff-2873f79a86c0d8b3335cd7731b0ecf7dd4301eb19a82ef7a1cba7589b5252261R88-R92

This PR fixes this bug, by removing WebhookServer from ctrl.Options. When WebhookServer == nil, ctrl.NewManager will create a webhook server with the default options, using 9443 port by default.