search

pfnet-research / gcp-workload-identity-federation-webhook

This webhook is for mutating pods that will require GCP Workload Identity Federation access from Kubernetes Cluster.
Apache License 2.0
43 stars 11 forks source link

Allow pre-release (EKS) kubernetes versions #70

Closed alanraison closed 3 months ago

alanraison commented 4 months ago

As described in https://github.com/helm/helm/issues/9371, adding -0 to the SemVer string allows pre-release versions to be included in the permitted versions. This is necessary for installing the chart on EKS.

Closes #69

ordovicia commented 3 months ago

Hmm, my understanding is:

alanraison commented 3 months ago

Hmm, my understanding is:

  • v1.30.1-eks-1de2ab1 is a pre-release version. EKS should use v1.30.1+eks.1de2ab1 instead to stick to SemVer spec. Amazon and other cloud providers does not follow SemVer habitually.
  • Helm and other tools, by default, ignores pre-release versions when determining if a version is in a range. It is correct behavior in the light of SemVer semantics.
  • By adding -0 to SemVer range, we can make Helm count in pre-release versions.

Yes this is correct. By using the tool vert, you can test the differences;

> vert ^1.20.0 v1.30.2-eks-db838b0
> echo $?
1
> vert ^1.20.0-0 v1.30.2-eks-db838b0
1.30.2-eks-db838b0
> echo $?
0
superbrothers commented 3 months ago

It may be possible to remove the kubeVersion itself. If we install Chart and it works fine, we can use it.