search

pfnet-research / menoh

Menoh: fast DNN inference library with multiple programming language support
MIT License
279 stars 34 forks source link

Build only master branch on appveyor #144

Closed okapies closed 6 years ago

okapies commented 6 years ago

Prevent running build on appveyor for both branch and PR other than master branch.

Ref. https://help.appveyor.com/discussions/questions/1700-pushing-a-feature-branch-schedules-two-builds

msakai commented 6 years ago

Sorry for the late reply.

Does the change mean that a branch does not go under CI until a pull request is made? If so, I'm worrying if it hampers doing CI on experimental branches. Because after this change, to run AppVeyor on an experimental branch, we need to make WIP PR for the branch or include a commit for modification of appveyor.yml.

okapies commented 6 years ago

Yes, we need a WIP PR after this fix. I think it is a good convention even if the branch is experimental. What do you think about it?

msakai commented 6 years ago

I see though I myself am not accustomed to such conventions.

okapies commented 6 years ago

Thanks! Fix it later if we face a problem in the future.