pfnet-research / menoh

Menoh: fast DNN inference library with multiple programming language support
MIT License
279 stars 34 forks source link

Fix tensorrt mul test #193

Closed okdshin closed 5 years ago

okdshin commented 5 years ago

This PR depends on #192

msakai commented 5 years ago

Sorry. I don't understand what the problem this PR fixes.

okdshin commented 5 years ago

Sorry, I lacked the description. TensorRT strictly distinguishes variable and parameter (parameter is constant) because batch axis is special in TensorRT. For the mul test, all inputs should be treated as variable. If it is not so, shape mismatch happens because variable and parameter have different shapes about batch axis. OP_TEST treats all inputs are variable. OP_TEST_STATIC_PARAMS treats the first input is variable and the others are parameters.

okdshin commented 5 years ago

Don't mind. Thank you for reviewing!