search

pfnet / PaintsChainer

line drawing colorization using chainer
https://paintschainer.preferred.tech/
MIT License
3.77k stars 556 forks source link

Using HSV/HSL instead of RGB #36

Closed Tedko closed 7 years ago

Tedko commented 7 years ago

Credit to @dsh0416 @fpsluozi

HSV/HSL is more suitable here for the task. Especially if we consider that the output image is relatively 'bright' than normal ones(input/test set). This might caused by that moving RGB simultaneously is more difficult than moving L/V in HSV/HSL.

Since RGB -> HSV/HSL is non-linear, here using RGB for training the network will consume several extra layers for doing the same thing but with less efficiency.

Tedko commented 7 years ago

@taizan also, for your training input, did you eliminate all black/white manga, etc?

taizan commented 7 years ago

Im using YUV for inner calculation, because loss calculation in HSV is a little bit tricky. I removed pure B/W image from training data target but still some less colored items may are in the datasets.

Tedko commented 7 years ago

Have you ever tried HSL? The loss calculation of L is easier. Though YUV should be enough for now. I am still considering how to get rid of the 'brightness' of the output.

taizan commented 7 years ago

oh, sorry for late reply, I m not tryed HSL yet.