search

pfnet / PaintsChainer

line drawing colorization using chainer
https://paintschainer.preferred.tech/
MIT License
3.77k stars 557 forks source link

Make pallet more useful #58

Closed taizan closed 7 years ago

taizan commented 7 years ago

Current pallet UI is not enough. For example , there is not enough skin colors or pastel colors. and too vivid color is not recommended for current model.

umyuu commented 7 years ago

Hello taizan. MyBranch enough skin colors　Correspondence. https://github.com/umyuu/PaintsChainer/commit/770f91ba139b5c85949def6bcc9494d90ec0f0e3 confirm. My Git Beginner.operation mistake sorry.

future Pull Request. The remaining 3 task.

1,Palet ColorCode. 1-1,ColorCode/SortOrder please confirm. 1-2,WebSafeColor Out of range. Yes/No.

2,Non Minfy Code Pull Request? Yes/No. wPaint/lib/wColorPicker.min.js …Minfy. MyBranch Code…No Minfy. →MyBranch OriginCode … wColorPicker v2.1.7 - 2013-09-27、rgbHex - v1.1.2 - 2013-09-27. https://github.com/websanova/wColorPicker/tree/master/src/wColorPicker.js 　No coding Guidelinerules please tell me.

3,Append Code 2 FiledNames please confirm Yes/No. ・skintoneColors ・skintoneColorPalette No Alternatives Names. ・humanskincolors ・enoughskincolors 　etc...

thank you for reading.

umyuu commented 7 years ago

Sorry. For your reference. Link OriginCode diff MyBranch Code. File wPaint/lib/wColorPicker.min.js Line 21,38,143,426-439.

abbychau commented 7 years ago

71

umyuu commented 7 years ago

Hello abbychau. Wonderful pull Request thank you.

taizan commented 7 years ago

Oh Thanks umyuu & abbychau ! OK I will check your commit .

umyuu commented 7 years ago

Hello taizan. Pull Request https://github.com/pfnet/PaintsChainer/pull/74 confirm. https://github.com/pfnet/PaintsChainer/issues/58#issuecomment-277433466