search

pfnet / pfio

IO library to access various filesystems with unified API
https://pfio.readthedocs.io/
MIT License
52 stars 20 forks source link

Fix `BufferedReader` error caused by opening an empty file in S3 in "rb" mode #270

Closed belltailjp closed 2 years ago

belltailjp commented 2 years ago

Fixes #269

belltailjp commented 2 years ago

/test

pfn-ci-bot commented 2 years ago

Successfully created a job for commit 3831f63:

pfn-ci-bot commented 2 years ago

Successfully created a job for commit 3831f63:

belltailjp commented 2 years ago

To me it's not actually urgent, because in my current workload specifically, empty files being created itself, maybe due to an unknown bug in my code or libraries, is problematic (eventually causes of another error). So I guess the release timing can be relatively flexible (of course making a release now is also super fine!).

kuenishi commented 2 years ago

Thanks for the details. For now, I'll put this for 2.3 schedule, until other issues in high priority come.