search

pfnet / pfrl

PFRL: a PyTorch-based deep reinforcement learning library
MIT License
1.2k stars 157 forks source link

fix incomplete arxiv link in double dqn #175

Closed zhouzypaul closed 2 years ago

muupan commented 2 years ago

Thanks for your PR, but http://arxiv.org/abs/1509.06461 is a valid url. The following period is a punctuation mark, which is correctly handled in the generated docs: https://pfrl.readthedocs.io/en/latest/agents.html#pfrl.agents.DoubleDQN. So I do not think this line needs a fix.

zhouzypaul commented 2 years ago

Oh I see. I was viewing it as a comment in the code on Github, and Github treats the entire line (including the dot) as the URL, and gave me an error when I tried to access it. I'll close the issue, thanks.