search

pfnet / pfrl

PFRL: a PyTorch-based deep reinforcement learning library
MIT License
1.2k stars 157 forks source link

Double IQN #4

Open prabhatnagarajan opened 4 years ago

prabhatnagarajan commented 4 years ago

Add Double IQN with a double update (as in ChainerRL - https://github.com/chainer/chainerrl/blob/master/chainerrl/agents/double_iqn.py)

cross32768 commented 4 years ago

Has anyone worked on this issue yet? If not, can I work on it?

prabhatnagarajan commented 4 years ago

Sure you can work on it!

Please consult this PR: https://github.com/chainer/chainerrl/pull/503 from chainerrl (as it with help with doing it in PyTorch), consult similar Double update implementations in PFRL (e.g. https://github.com/pfnet/pfrl/blob/master/pfrl/agents/categorical_double_dqn.py) and the contributing guide.

cross32768 commented 4 years ago

Thank you for your kind responce! I add some code based on your advice and made pull request #69 for this issue.